Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify API docs for OnAfterRender #49519

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Clarify API docs for OnAfterRender #49519

merged 3 commits into from
Jul 28, 2023

Conversation

danroth27
Copy link
Member

Fixes #49518.

@danroth27 danroth27 requested a review from a team as a code owner July 19, 2023 16:49
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Jul 19, 2023
mkArtakMSFT
mkArtakMSFT approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include Steve's suggestion. Thanks!

@guardrex guardrex mentioned this pull request Jul 27, 2023
Closed
@danroth27 @SteveSandersonMS
Update src/Components/Components/src/ComponentBase.cs
5a3701c 
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@danroth27 danroth27 enabled auto-merge (squash) July 28, 2023 16:23
@danroth27 danroth27 merged commit 90f6a22 into main Jul 28, 2023
@danroth27 danroth27 deleted the danroth27/onafterrender branch July 28, 2023 17:40
@ghost ghost added this to the 8.0-rc1 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolassargos nicolassargos nicolassargos left review comments

@SteveSandersonMS SteveSandersonMS SteveSandersonMS left review comments

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
8.0-rc1
4 participants
@danroth27 @SteveSandersonMS @nicolassargos @mkArtakMSFT